app/vmui: show selected time zone offset in header controls - #1655
Open
Loori-R wants to merge 1 commit into
Open
app/vmui: show selected time zone offset in header controls#1655Loori-R wants to merge 1 commit into
Loori-R wants to merge 1 commit into
Conversation
Loori-R
added
the
web-ui
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
hagen1778
approved these changes
Aug 4, 2026
func25
approved these changes
Aug 6, 2026
func25
left a comment
func25
left a comment
Member
There was a problem hiding this comment.
LGTM, you've probably discussed this, but just wanted to share the view. The timezone feature isn't used very often, so I think it's fine to access it by clicking on the time. This would avoid overwhelming most of users, as the main vmui page has too many things already.
|
|
||
| {headerSetup?.tenant && <Tenants/>} | ||
| {headerSetup?.timeSelector && <TimeSelector onOpenSettings={settingsRef?.current?.open}/>} | ||
| <TimeZonePreview onOpenSettings={() => settingsRef.current?.open()}/> |
Member
There was a problem hiding this comment.
Could we also port the related TimeSelector change from VictoriaMetrics PR 11332? Its clickable timezone row is still a div
VM:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Make the selected timezone offset more visible and provide quicker access to timezone settings.
Mirror of VictoriaMetrics/VictoriaMetrics#11332
Changes
Screenshots